Conversation
Signed-off-by: Sebastian Mendel <info@sebastianmendel.de>
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
There was a problem hiding this comment.
Pull request overview
This PR adds a new CI job to validate skill repository structure and content by calling a reusable workflow from the netresearch/skill-repo-skill repository. The validation checks SKILL.md frontmatter, word count, composer.json, plugin.json, and file presence to ensure the repository meets skill standards.
Changes:
- Added
validatejob to lint.yml workflow that calls a reusable workflow for skill validation
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| validate: | ||
| name: Skill Validation | ||
| uses: netresearch/skill-repo-skill/.github/workflows/validate.yml@main |
There was a problem hiding this comment.
The reusable workflow reference uses @main which is a mutable branch reference. All other action references in this repository use pinned commit SHAs for security (e.g., @de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2). Using @main allows the referenced workflow to change without your knowledge, potentially introducing malicious code or breaking changes. Consider pinning to a specific commit SHA or at minimum a tagged version, following the established pattern in this codebase.
| uses: netresearch/skill-repo-skill/.github/workflows/validate.yml@main | |
| uses: netresearch/skill-repo-skill/.github/workflows/validate.yml@v1 |
| SHELLCHECK_OPTS: -x | ||
|
|
||
| validate: | ||
| name: Skill Validation |
There was a problem hiding this comment.
The validate job does not explicitly define permissions. When calling a reusable workflow, permissions are not inherited by default from the caller workflow. If the reusable workflow needs to access repository contents or other resources, you may need to explicitly pass permissions using the 'permissions' key at the job level, or ensure the reusable workflow has 'permissions: read-all' or specific permissions defined. Verify whether the netresearch/skill-repo-skill validate.yml workflow requires any specific permissions.
| name: Skill Validation | |
| name: Skill Validation | |
| permissions: | |
| contents: read |
Summary
Test plan